Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang packages and update HTTP URLs #20

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Add lang packages and update HTTP URLs #20

merged 2 commits into from
Apr 12, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Apr 12, 2024

What was changed

  • Added needed lang-specific options to top of files
  • Updated HTTP API annotations to have /api/v1/cloud/ prefix to make this easier to edge route when combined with other HTTP API on the same endpoint (this may change again)
  • Added comment to top of cloud service saying it is experimental and may change incompatibly
  • Couple of API linter ignores (these aren't really needed since this repo isn't merging into primary one yet, can remove if necessary)
  • Fixed end-of-file newline inconsistency

Once merged, I can use git submodule/subtree to allow this to be referenced in the primary API repo. Do y'all want me to disable the buf-breaking check in code (to re-enable in later PR) or do y'all want to admin-bypass?

@cretz cretz requested a review from a team April 12, 2024 13:17
@anekkanti anekkanti merged commit 89ba5e1 into main Apr 12, 2024
2 of 3 checks passed
@cretz cretz deleted the proto-extra branch April 12, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants