Update Multi-Region Namespace APIs #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
May 14, 2024
Co-authored-by: Chad Retz <[email protected]>
Co-authored-by: Chad Retz <[email protected]>
cretz
approved these changes
May 14, 2024
mastermanu
reviewed
May 14, 2024
mastermanu
reviewed
May 14, 2024
| } | ||
|
|
||
| message AddNamespaceRegionRequest { | ||
| // The namespace to add region to. |
There was a problem hiding this comment.
"The namespace to add the region to"
mastermanu
reviewed
May 14, 2024
| message AddNamespaceRegionRequest { | ||
| // The namespace to add region to. | ||
| string namespace = 1; | ||
| // The id of the region to add to the namespace. |
There was a problem hiding this comment.
Do we need any clarification comment here that this is secondary/passive region?
mastermanu
reviewed
May 14, 2024
| } | ||
|
|
||
| message NamespaceRegionStatus { | ||
| // The current state of the namespace region. |
There was a problem hiding this comment.
[Nit] might want to reword this a bit as this could be interpreted as "the state of the whole region the namespace is in"
Maybe, the current state of the namespace in the given region or something would be better?
There was a problem hiding this comment.
This is the state of a region where the namespace is in.
mastermanu
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Update Multi-Region Namespace APIs
Why?
Update Multi-Region Namespace APIs
Checklist
Closes
How was this tested: