This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This contains a few changes and fixes we made during our load testing journey:
TLS_SERVER_NAME
environment variableTLS_CLIENT_CERT_PRIVATE_KEY_File
environment variable (should be all uppercase, probably a copy'n'paste mistake)go fmt
which improves the general readability of the codeThe biggest change in terms of lines was reducing the amount of logs produced. Without at least some changes Maru produces tens of thousands of lines of logs for even small and medium sized scenarios.
Why?
These changes make the project easier to work with when running a lot of scenarios on a regular basis.
Checklist
How was this tested:
We ran extensive load tests using the updated version. We opened a fork-internal pull request for reference (Misc fixes alfatraining/maru#1) which isn't going to be merged and also contains a couple more changes we felt we shouldn't try to upstream.
Any docs updates needed?
No, not yet. Some changes affect the Helm chart but that's not published and doesn't have any documentation.