Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Enable custom pod annotations #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arihantsethia
Copy link

@arihantsethia arihantsethia commented Mar 16, 2024

What was changed

Allows users to define custom pod level annotations

Why?

This unlocks the capbility to provide additional configuration option for external systems (e.g. istio sidecar resources)

Checklist

How was this tested:
Validated charts being generated with annotations when configured.

with podAnnotations :

apiVersion: apps/v1
kind: Deployment
metadata:
  name: maru-temporal-bench
  labels:
    ...
spec:
  replicas: 2
  selector:
    matchLabels:
      app.kubernetes.io/name: temporal-bench
      app.kubernetes.io/instance: maru
  template:
    metadata:
      labels:
        app.kubernetes.io/name: temporal-bench
        app.kubernetes.io/instance: maru
      annotations:
        prometheus.io/job: temporal-bench
        prometheus.io/scrape: 'true'
        prometheus.io/port: '9090'
        sidecar.istio.io/proxyCPU: 200m
        sidecar.istio.io/proxyMemory: 512Mi
        sidecar.istio.io/proxyMemoryLimit: 512Mi

without annotations

apiVersion: apps/v1
kind: Deployment
metadata:
  name: maru-temporal-bench
  labels:
    ...
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: temporal-bench
      app.kubernetes.io/instance: maru
  template:
    metadata:
      labels:
        app.kubernetes.io/name: temporal-bench
        app.kubernetes.io/instance: maru
      annotations:
        prometheus.io/job: temporal-bench
        prometheus.io/scrape: 'true'
        prometheus.io/port: '9090'

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2024

CLA assistant check
All committers have signed the CLA.

@arihantsethia arihantsethia marked this pull request as ready for review March 16, 2024 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants