Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running semgrep on merge groups #4

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

XaF
Copy link
Contributor

@XaF XaF commented Jan 11, 2024

Semgrep is taking an awful amount of time when running in merge queues, this is disabling it for those cases while keeping the workflow running to fit the requirement.

What was changed

Disable semgrep runs on merge queues.

Why?

Because semgrep seems to take an awful lot of time when running on merge queues, since it reevaluates the whole code.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Semgrep is taking an awful amount of time when running in merge queues, this is disabling it for those cases while keeping the workflow running to fit the requirement.
@XaF XaF requested a review from a team as a code owner January 11, 2024 15:38
@XaF XaF requested a review from jackdawm January 11, 2024 15:39
Copy link
Contributor

@jackdawm jackdawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pairing on this!

@jackdawm jackdawm merged commit b8fe73e into main Jan 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants