Skip to content

Commit

Permalink
Add UNSPECIFIED to every enum. (#158)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexshtin authored Jun 10, 2020
1 parent ac02e4f commit 5165b45
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ require (
github.com/uber-go/tally v3.3.17+incompatible
github.com/uber/jaeger-client-go v2.23.1+incompatible
github.com/uber/jaeger-lib v2.2.0+incompatible // indirect
go.temporal.io/temporal-proto v0.23.6
go.temporal.io/temporal-proto v0.24.0
go.uber.org/atomic v1.6.0
go.uber.org/goleak v1.0.0
go.uber.org/zap v1.15.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ github.com/uber/jaeger-client-go v2.23.1+incompatible/go.mod h1:WVhlPFC8FDjOFMMW
github.com/uber/jaeger-lib v2.2.0+incompatible h1:MxZXOiR2JuoANZ3J6DE/U0kSFv/eJ/GfSYVCjK7dyaw=
github.com/uber/jaeger-lib v2.2.0+incompatible/go.mod h1:ComeNDZlWwrWnDv8aPp0Ba6+uUTzImX/AauajbLI56U=
github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
go.temporal.io/temporal-proto v0.23.6 h1:MHUDqJB2nptBSjZcDZMt/vv1rC8L0grTvwoRYHJwAG0=
go.temporal.io/temporal-proto v0.23.6/go.mod h1:lFt53MEhtjHIJtgg1U1Fdx3e3HoBOZcZKEbElzYz5Ro=
go.temporal.io/temporal-proto v0.24.0 h1:4fHSBv4PIJuRJAU6l5ANrp9tOvXVB1c1mfShKYbpzlI=
go.temporal.io/temporal-proto v0.24.0/go.mod h1:lFt53MEhtjHIJtgg1U1Fdx3e3HoBOZcZKEbElzYz5Ro=
go.uber.org/atomic v1.6.0 h1:Ezj3JGmsOnG1MoRWQkPBsKLe9DwWD9QeXzTRzzldNVk=
go.uber.org/atomic v1.6.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
go.uber.org/goleak v1.0.0 h1:qsup4IcBdlmsnGfqyLl4Ntn3C2XCCuKAE7DwHpScyUo=
Expand Down
4 changes: 3 additions & 1 deletion internal/internal_task_handlers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1444,7 +1444,9 @@ func (t *TaskHandlersTestSuite) TestActivityExecutionWorkerStop() {
}

func Test_NonDeterministicCheck(t *testing.T) {
decisionTypes := decisionpb.DecisionType_value
decisionTypes := decisionpb.DecisionType_name
delete(decisionTypes, 0) // Ignore "Unspecified".

require.Equal(t, 13, len(decisionTypes), "If you see this error, you are adding new decision type. "+
"Before updating the number to make this test pass, please make sure you update isDecisionMatchEvent() method "+
"to check the new decision type. Otherwise the replay will fail on the new decision event.")
Expand Down

0 comments on commit 5165b45

Please sign in to comment.