-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump junit xml #1634
base: master
Are you sure you want to change the base?
Dump junit xml #1634
Conversation
4152931
to
f83ff64
Compare
@@ -3,18 +3,27 @@ github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03 | |||
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c h1:pxW6RcqyfI9/kWtOwnv/G+AzdKuy2ZrqINhenH4HyNs= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes to go.mod
and go.sum
are the result of running go get gotest.tools/gotestsum
(looks like it was already a transitive dependency IIUC).
37002b4
to
91e7954
Compare
@Quinn-With-Two-Ns To output junit XML I had to switch to using |
No concern about the test format. Question about the general PR though, from the issue it says
Does that appropriate tool exist yet today? |
Good question. I couldn't find something that would work well, e.g. correlating tests across our matrix builds, so I've started creating our own from scratch. I'm not quite ready to have others test it (but absolutely welcome any help developing it). |
TEMP: just install gotestsum in ci.yml Invoke gotestsum correctly go get gotest.tools/gotestsum Install gotestsum locally Pass file stem from ci.yml; allow build script to control output dir Dump junit XML for cloud test also Delete unnecessary quotes Add comment on duplicated hardcoded path
e37808b
to
283216c
Compare
Closes #1633