Add workflow init support #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
issue-865
branch
from
c97b51f
to
9f334db
Compare
cretz
approved these changes
Sep 16, 2024
| for (Constructor<?> ctor : clazz.getDeclaredConstructors()) { | ||
| WorkflowInit wfInit = ctor.getAnnotation(WorkflowInit.class); | ||
| if (wfInit == null) { | ||
| if (ctor.getParameterCount() == 0) { |
There was a problem hiding this comment.
Suggested change
| if (ctor.getParameterCount() == 0) { | |
| if (ctor.getParameterCount() == 0 && Modifier.isPublic(ctor.getModifiers())) { |
Small thing, but I figure we want to ensure default constructor is public (I assume this isn't backwards incompatible as it would have broken before) and ignore non-public constructors
Quinn-With-Two-Ns
force-pushed
the
issue-865
branch
from
9f334db
to
2466d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workflow init support to allow users to run code before signal/update handlers:
@WorkflowInit@WorkflowInitwe treat exceptions thrown by as if they are thrown from the main workflow methodcloses #865