Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static flags into DTO for Worker Factory #505

Closed
wants to merge 1 commit into from

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Sep 17, 2024

What was changed

Static worker flags have been refactored to DTOs.
Now, the DTO with flags can be passed to the service container when creating the Worker Factory.

$factory = WorkerFactory::create(
    converter: $converter,
    flags: FeatureFlags::createDefaults(),
);

FeatureFlags class has two factories: createDefaults and createLegacy (any ideas for better naming?).
The first sets the flags to meet current SDK requirements.
createLegacy sets the flags to ensure compatibility with the project codebase written for SDK versions <2.11.0.

By default we create FeatureFlags using legacy set

Why?

See #494 (comment)

@roxblnfk roxblnfk added this to the 2.11.0 milestone Sep 17, 2024
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 2:48pm

@roxblnfk
Copy link
Collaborator Author

Closed in favor of #510

@roxblnfk roxblnfk closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant