Move static flags into DTO for Worker Factory #505
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Static worker flags have been refactored to DTOs.
Now, the DTO with flags can be passed to the service container when creating the Worker Factory.
FeatureFlags
class has two factories:createDefaults
andcreateLegacy
(any ideas for better naming?).The first sets the flags to meet current SDK requirements.
createLegacy
sets the flags to ensure compatibility with the project codebase written for SDK versions<2.11.0
.By default we create FeatureFlags using legacy set
Why?
See #494 (comment)