-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved documentation with Spatie\Permissions #100
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load order should read 'CacheServiceProvider' as opposed to 'AppServiceProvider'
Also if user is using Redis as session store, the new CacheServiceProvider must be loaded before SessionServiceProvider. |
The current example returns null from CLI as the config file driver.php doesn't even exist. Perhaps better alternative would be to set the $uuid variable simply to 'cli'. |
Ended up going with Redis based caching for the domains. Join query is sort of expensive.
|
Feel like this should be moved to the docs regarding laravel-permissions 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one comment, perfect PR. Like I said in a comment, feel like this should be moved to the spatie/permissions tutorial we have, you could add a footnote/sidenote in the cache docs to refer to that specific section in the tutorial.
@@ -51,3 +51,26 @@ allows you to set a custom cache driver in `config/cache.php`: | |||
|
|||
> Make sure the CacheServiceProvider is registered in `config/app.php` or else your driver will | |||
not be available for use. | |||
|
|||
If you are using Spatie\Permission package and receive error about driver `redis_tenancy` is not supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spatie/laravel-permission
please :)
No description provided.