-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Laravel 11. #1047
base: 5.x
Are you sure you want to change the base?
Upgrade to Laravel 11. #1047
Conversation
@mikebronner Thank you for starting the effort on this, let us know if there's anything we can do to help update this package. |
Looking for upgrade to laravel 11, thank you! |
After testing this for several months now on my clients I have not encountered any issues. @ArlonAntonius marking this ready for review. Although I have not used the two file methods. Could use some help implementing those. |
@mikebronner have you really been tesing it in production like this? |
@ArlonAntonius Yes, correct, but with the caveat that we have not been using file uploads in our multi-tenant apps. I assume the CI issues are from Laravel 11 now requiring PHP 8.2+, but I am unable to see why the CI is failing (when I click on the link it asks me to log in). |
public function putFile($path, $file = null, $options = []) | ||
{ | ||
// tba | ||
} | ||
|
||
public function putFileAs($path, $file, $name = null, $options = []) | ||
{ | ||
// tba | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikebronner Maybe the only thing that still needs to be added are these methods to make sure nobody's application actually fails. Other than that: I'm fine with merging this
No description provided.