Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Starport for better development environment #203

Open
4 tasks done
jaybxyz opened this issue Oct 28, 2021 · 2 comments · May be fixed by #231
Open
4 tasks done

feat: add Starport for better development environment #203

jaybxyz opened this issue Oct 28, 2021 · 2 comments · May be fixed by #231
Assignees
@jaybxyz
Labels
enhancement New feature or request

Comments

@jaybxyz
Copy link
Contributor

jaybxyz commented Oct 28, 2021 •
edited
Loading

Summary

Right now, the farming module uses localnet script to run local network for testing local environment. This issue proposes to add Starport for better development environment so that just by running starport chain serve command, you can run local network with various different functionalities that Starport supports.

Tasks

  • Add config.yml to add Starport
  • Update README.mdand TECHNICAL_SETUP.md docs
  • Remove scripts/localnet.sh and update Makefile
  • Remove most of the third_party proto files

References

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jaybxyz jaybxyz added the enhancement New feature or request label Oct 28, 2021
@jaybxyz jaybxyz self-assigned this Oct 28, 2021
@jaybxyz jaybxyz linked a pull request Nov 23, 2021 that will close this issue
Draft
13 tasks
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Nov 25, 2021 •
edited
Loading

The farming module is planning to release the next version tomorrow. I think this PR is better not to be merged in the next version since I don't have strong confidence at this point. As I integrate Starport into the module, I find out there are tradeoffs (e.g proto-format functionality when starport g proto-gen and there should exist scaffold inline comments in order to fully utilize Starport subcommands and etc). There might be workarounds for those issues or there are some stuff that I don't know yet. Therefore, I think I need to spend more time playing with it.

@dongsam
Copy link
Contributor

dongsam commented Nov 25, 2021

The farming module is planning to release the next version tomorrow. I think this PR is better not to be merged in the next version since I don't have strong confidence at this point. As I integrate Starport into the module, I find out there are tradeoffs (e.g proto-format functionality when starport g proto-gen and there should exist scaffold inline comments in order to fully utilize Starport subcommands and etc). It might be because I don't know there is a workaround or there are some stuff that I don't know yet. Therefore, I think I need to spend more time playing with it.

I agree, Let's continue it after starport starts supporting cosmos-sdk 0.44.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaybxyz jaybxyz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add starport for better development environment jaybxyz/farming
2 participants
@dongsam @jaybxyz