Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add starport for better development environment #231

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Nov 23, 2021

Description

This PR adds starport to improve development environment. While integrating it to the module, I discover that starport generate proto-go command doesn't have inner functionality to format proto files, so I created this issue to request for the integration if possible. It may be better to wait until the issue gets resolved, but if it takes a long time then we can just leave proto-format target in Makefile.

Usage of Starport CLI can be found in this docs.

closes: #203

Tasks

  • Add config.yml to support serve chain locally with Starport CLI
  • Remove most of third party proto files since Starport links those
  • Remove scripts/localnet.sh and update Makefile
  • Update related docs TECHNICAL_SETUP.md

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Nov 23, 2021
@dongsam
Copy link
Contributor

dongsam commented Nov 24, 2021

Could we add curl https://get.starport.network/starport! | bash command on the docs? So that you can install it right away without checking starport document https://docs.starport.com/guide/install.html#installing-starport

# Conflicts:
#	x/farming/types/farming.pb.go
#	x/farming/types/genesis.pb.go
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Nov 25, 2021

The farming module is planning to release the next version tomorrow. I think this PR is better not to be merged in the next version since it requires more tests with Starport. I will label this PR as wontfix for now.

@jaybxyz jaybxyz added the wontfix This will not be worked on label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add Starport for better development environment
2 participants