Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed installing extra addons from afterInstall hook #14 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,39 +12,37 @@ ember install https://github.com/tenforce/ember-mu-application-generator.git
ember generate ember-mu-application-generator
```

The ember generate is needed, because on install the application should install some necessary files (transforms, utils, etc.) and addons (ember-power-select, ember-changeset). If ember installation is done with a git url, ember install cannot find the package name and install the default blueprint (where packagename == blueprintname).

If it's needed, you can modify the url with a tag or a branch:
```
ember install https://github.com/tenforce/ember-mu-application-generator.git#tag
ember install https://github.com/tenforce/ember-mu-application-generator.git#branch
```

### Ember 2.14

To use the addon with Ember version >=2.14 and <3.0.0, make sure to use the good tag:

```
ember install https://github.com/tenforce/ember-mu-application-generator.git#ember-2.14
```
The ember generate is needed, because on install the application should install some necessary files (transforms, utils, etc.). If ember installation is done with a git url, ember install cannot find the package name and install the default blueprint (where packagename == blueprintname). Don't forget to install the dependencies too!

### Dependencies

This addon requires the following addons:
- [ember-power-select](https://github.com/cibernox/ember-power-select)
- [ember-changeset](https://github.com/DockYard/ember-changeset)
- [ember-datetimepicker](https://github.com/kellyselden/ember-datetimepicker)
- [ember-datetimepicker](https://github.com/kellyselden/ember-datetimepicker) The `ember-datetimepicker` addon needs `jquery-datetimepicker`.

If they are not installed with the `ember generate ember-mu-application-generator`, then please install them manually.
They are not installed with the `ember generate ember-mu-application-generator`, please install them manually.

```
ember install ember-power-select
ember install ember-changeset
ember install ember-datetimepicker
```

The ember-datetimepicker addon needs jquery-datetimepicker to be able to run. Somehow the addon doesn't ember install it correctly, so make sure to use `ember install ember-datetimepicker` command!
### Different version
If it's needed, you can modify the url with a tag or a branch:
```
ember install https://github.com/tenforce/ember-mu-application-generator.git#tag
ember install https://github.com/tenforce/ember-mu-application-generator.git#branch
```

### Ember 2.14

To use the addon with Ember version >=2.14 and <3.0.0, make sure to use the good tag:
```
ember install https://github.com/tenforce/ember-mu-application-generator.git#ember-2.14
```

### Design installation

Expand Down
6 changes: 1 addition & 5 deletions blueprints/ember-mu-application-generator/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ module.exports = {

// to install important packages
afterInstall: function(options) {
updateRouter.call(this, 'add', options);
this.addPackageToProject('jquery-datetimepicker', '^2.5.4');
this.addAddonToProject('ember-power-select', '^1.9.3');
this.addAddonToProject('ember-datetimepicker', '^2.1.0');
return this.addAddonToProject('ember-changeset', '~1.3.0');
return updateRouter.call(this, 'add', options);
},

afterUninstall: function(options) {
Expand Down