Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CICD]Enhance project's compatibility #361

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

poinwater
Copy link
Contributor

@poinwater poinwater commented Sep 15, 2023

Description

Brief Description of the PR:
This pull request aims to enhance the project's compatibility by making it compatible with TensorFlow versions 2.6.0 to 2.11.0.

Type of change

  1. Added compatible import statements for Adam, Version, and data_structures.
  2. Updated the building scripts and Docker files.
  3. Decoupled TensorFlow dependencies so that users don't need to reinstall TensorFlow with the TFRA wheels.
  4. Added CI/CD tasks to build wheels with both the minimum and maximum TensorFlow versions.
  • Bug fix
  • CICD
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature, please describe the tests that you ran to verify your changes:

I tested the CI/CD with multiple TensorFlow versions in my repository. The code is working with TensorFlow versions between 2.6.0 to 2.11.0. However, for simplifying the pipeline, I only kept the minimum tasks.

@poinwater poinwater marked this pull request as ready for review September 17, 2023 01:25
@poinwater
Copy link
Contributor Author

Not sure why it's closed

Copy link
Collaborator

@MoFHeka MoFHeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong
Copy link
Member

rhdong commented Oct 27, 2023

Hi @poinwater, please use rebase on master instead of merge master, thank you~

@rhdong rhdong merged commit 82e473a into tensorflow:master Oct 27, 2023
39 checks passed
@poinwater poinwater deleted the r-tf-version-test branch May 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants