[fix] DEHvdCheckpoint failed when importing Horovod unsuccessfully. #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…would not call DE variable saving and sweeping redundant DE files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When result of importing Horovod is None, TFRA DEHvdCheckpoint would not call DE variable saving and sweeping redundant DE files.
This problem because I forgot writing the correct code when importing horovod.tensorflow is None in _de_hvd_write_fs_func. Local variable 'de dir' referenced before assignment when self._hvd is None.
Type of change
Checklist:
How Has This Been Tested?
Uninstalling Horovod and using DEHvdCheckpoint.