Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] horovod example and gpu unit test #442

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

jq
Copy link
Collaborator

@jq jq commented Jun 26, 2024

Description

  • fix load model bug

  • remove un-used self.gpu_device self.cpu_device

  • enable

sh start.sh 1
to test only 1 steps_per_epoch

  • add inference
  • fix GPU unit tests

Brief Description of the PR:

Fixes # (issue)

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@jq jq requested a review from rhdong as a code owner June 26, 2024 19:18
@jq jq force-pushed the tuning branch 5 times, most recently from afdcdb0 to cc45709 Compare June 27, 2024 19:50
@jq jq changed the title [FIX] horovod example [FIX] horovod example and gpu unit test Jun 27, 2024
@jq jq force-pushed the tuning branch 8 times, most recently from ac77768 to 44fbd29 Compare June 28, 2024 17:54
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit a8642aa into tensorflow:master Jun 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants