-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy example gen prod #226
Copy example gen prod #226
Conversation
Thanks for the PR! 🚀 Instructions: Approve using |
…rtex with StatisticsGen, Trainer, and Pusher
…rtex with StatisticsGen, Trainer, and Pusher
…rtex with StatisticsGen, Trainer, and Pusher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if the changes to component.py aren't clear. It's important to clean that loop up.
@@ -10,31 +10,73 @@ | |||
**Project name:** CopyExampleGen component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add copyright to the readme. Use The Tensorflow Authors (not Google -- see other files in addons).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see any copyright lines in other readme files. May you link me to an example? @michaelwsherman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could we add some tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to wait until tests are added, but I think the current authors are off doing other things so it's best to accept this for now and someone can add tests later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/merge
CopyExampleGen component #66:
First pull request for CopyExampleGen component.py file.