Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(tur/pacman-contrib): 1.10.6 #1257

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

TomJo2000
Copy link
Collaborator

@TomJo2000 TomJo2000 commented Oct 13, 2024

This came up in the Discord, specifically the systemd services not being removed.
So I decided to take a look at a build script and to be diplomatic this was just really damn sloppy.
I overhauled the build script and updated the package to the latest version.

I don't want to keep banging on about this, but I just want to quickly point out how many problems the old build script had.

  • Systemd services were not being removed
  • paclist was getting shipped despite supposedly being disabled
    because accessing an array without an index only returns the first element.
    local disabledUtils=(checkupdates paclist)
    local util=
    for util in $disabledUtils;do
  • That entire removal shenanigans should have been put into termux_step_post_massage()
    Or better yet just use TERMUX_PKG_RM_AFTER_INSTALL which is the control variable specifically for removing files from a package.
  • Auto updates were only half disable, I've turned them back on as a test.
  • No sv services were being provided as equivalents to the Systemd services.
  • PKG_CONFIG_PATH was being exported to its existing default value for no apparent reason

overhaul build script
@TomJo2000
Copy link
Collaborator Author

Actually have no idea why those two are being removed.
Both should work just fine.
checkupdates might need a small patch, will look into that later.

@licy183 licy183 merged commit b515539 into termux-user-repository:master Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants