Skip to content

Commit

Permalink
fix(main/toxic): enable openal and x11 to receive video and audio fro…
Browse files Browse the repository at this point in the history
…m calls

Fixes `video_call.c:58:16: error: no member named 'av' in 'struct Toxic'` during build when `libx11`, `libvpx` and `openal-soft` all happened to be installed in the prefix before compiling `toxic` (the manifestation of JFreegman/toxic#483 in termux-packages)

This one is a bit of a far-out suggestion, but I noticed that audio **receiving** (openal playback) and video **receiving** (x11 render video stream) both **do** work if I actually install this build in Termux, open Termux:X11, open a terminal in Termux:X11, set up a Tox client on a desktop PC, add the client on Termux as a friend, start a call with it, set my microphone and webcam on the desktop PC client, turn on my camera on the desktop PC client, and watch and listen for the output on the Android device.

neither video **sending** (v4l2 recording) nor audio **sending** (openal recording) work, so the Termux:X11 client is only able to hear and see the other call participants and other participants can't hear or see the Termux:X11 client (though chat messages work), but I wondered whether that means that the X11 and openal support both have to remain completely disabled, or if it is worth it at all to enable them.
  • Loading branch information
robertkirkman committed Nov 1, 2024
1 parent fba6c5e commit cb1d594
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
4 changes: 3 additions & 1 deletion packages/toxic/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ TERMUX_PKG_DESCRIPTION="A command line client for Tox"
TERMUX_PKG_LICENSE="GPL-3.0"
TERMUX_PKG_MAINTAINER="@termux"
TERMUX_PKG_VERSION="0.15.1"
TERMUX_PKG_REVISION=1
TERMUX_PKG_SRCURL=https://github.com/JFreegman/toxic/archive/v${TERMUX_PKG_VERSION}/toxic-${TERMUX_PKG_VERSION}.tar.gz
TERMUX_PKG_SHA256=56cedc37b22a1411c68fd8b395f40f515d6a4779be02540c5cd495665caa127c
TERMUX_PKG_AUTO_UPDATE=true
TERMUX_PKG_DEPENDS="c-toxcore, libconfig, libcurl, libqrencode, ncurses, zlib"
# audio and video sending in calls does not work. audio and video receiving in calls does work.
TERMUX_PKG_DEPENDS="c-toxcore, libconfig, libx11, libvpx, openal-soft, libcurl, libqrencode, ncurses, zlib"
TERMUX_PKG_BUILD_IN_SRC=true

termux_step_make() {
Expand Down
12 changes: 0 additions & 12 deletions packages/toxic/cfg-checks-audio.mk.patch

This file was deleted.

0 comments on commit cb1d594

Please sign in to comment.