Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addpkg(main/cyclone): 0.36.0 #20560

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

addpkg(main/cyclone): 0.36.0 #20560

wants to merge 2 commits into from

Conversation

tqfx
Copy link
Contributor

@tqfx tqfx commented Jun 16, 2024

Close #20535

@TomJo2000
Copy link
Member

TomJo2000 commented Jun 16, 2024

Looking at @cattokomo's work, it seems like libck doesn't work for arm.
Maybe some of the other patches can be useful for getting i686 building.
https://github.com/cattokomo/termux-packages/tree/add-libck-cyclone/packages/cyclone

@mbekkomo
Copy link
Contributor

@TomJo2000 About arm support for libck, there's on-going issue available in the repository, to be exact concurrencykit/ck#231.

@TomJo2000
Copy link
Member

I'd say we blacklist arm for now, and if there's a PR made to fix it we can either cherry pick that patch, or enable it in the next version.

@tqfx
Copy link
Contributor Author

tqfx commented Jun 16, 2024

$ winds
Error: Unable to open output memory stream: 0
Call history, most recent first:
[1] libs/util.sld:string-join
[2] scheme/base.sld:foldl
[3] scheme/base.sld:reverse
[4] scheme/base.sld:fast-string=?
[5] libs/util.sld:trim-trailing-slash
[6] libs/util.sld:->string
[7] scheme/base.sld:fast-string=?
[8] libs/util.sld:trim-trailing-slash
[9] libs/util.sld:->string

@tqfx
Copy link
Contributor Author

tqfx commented Jun 18, 2024

~ $ winds install json
Downloading json 0.1.0...
Downloading packrat 0.2.0...
Building and installing packrat...
gc_move: bad tag obj=0x7fd9d9c4f0 obj.tag=50
An error occurred (Could not compile file /data/data/com.termux/files/usr/tmp/packrat513249163/cyclone/packrat.sld. Return code 256)

@tqfx
Copy link
Contributor Author

tqfx commented Jun 23, 2024

~ $ winds install json
Downloading json 0.1.0...
Downloading packrat 0.2.0...
Building and installing packrat...
gc_move: bad tag obj=0x7fd9d9c4f0 obj.tag=50
An error occurred (Could not compile file /data/data/com.termux/files/usr/tmp/packrat513249163/cyclone/packrat.sld. Return code 256)

Fixed with workaround.

@tqfx tqfx marked this pull request as ready for review June 23, 2024 07:28
@tqfx
Copy link
Contributor Author

tqfx commented Jun 23, 2024

test on device

~/.../cyclone/src $ make test
./cyclone -I libs -COPT '-Iinclude' -CLNK '-L.' tests/base.scm
./tests/base
�[1mvector literals: �[0m..
�[32m2 out of 2 (100.0%)�[39m tests passed in 0.0 seconds.
�[1mstrings: �[0m.
�[32m1 out of 1 (100.0%)�[39m test passed in 0.0 seconds.
�[1mmake-list: �[0m.
�[32m1 out of 1 (100.0%)�[39m test passed in 0.0 seconds.
�[1mrationals: �[0m....
�[32m4 out of 4 (100.0%)�[39m tests passed in 0.0 seconds.
�[1mnumeric operations - floor, truncate, : �[0m...................................
�[32m35 out of 35 (100.0%)�[39m tests passed in 0.0 seconds.
�[1mexact: �[0m.....
�[32m5 out of 5 (100.0%)�[39m tests passed in 0.0 seconds.
�[1mrecords: �[0m..
�[32m2 out of 2 (100.0%)�[39m tests passed in 0.0 seconds.
�[1massoc: �[0m......
�[32m6 out of 6 (100.0%)�[39m tests passed in 0.0 seconds.
�[1mmember: �[0m......
�[32m6 out of 6 (100.0%)�[39m tests passed in 0.0 seconds.
rm -rf tests/base tests/base.c tests/base.o
./cyclone -I libs -COPT '-Iinclude' -CLNK '-L.' tests/test.scm
./tests/test
�[1massert: �[0m.
�[32m1 out of 1 (100.0%)�[39m test passed in 0.0 seconds.
�[1mnot: �[0m.
�[32m1 out of 1 (100.0%)�[39m test passed in 0.0 seconds.
rm -rf tests/test tests/test.c tests/test.o
./cyclone -I libs -COPT '-Iinclude' -CLNK '-L.' tests/threading.scm
./tests/threading
�[1mthread-join!: �[0m.
�[32m1 out of 1 (100.0%)�[39m test passed in 0.0 seconds.
rm -rf tests/threading tests/threading.c tests/threading.o
./cyclone -I libs -COPT '-Iinclude' -CLNK '-L.' tests/unit-tests.scm
./tests/unit-tests


(138 tests passed with no errors)
rm -rf tests/unit-tests tests/unit-tests.c tests/unit-tests.o

@twaik
Copy link
Member

twaik commented Oct 19, 2024

Marking this as draft, let's wait until concurrencykit/ck#231 is being resolved.

@twaik twaik marked this pull request as draft October 19, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package]: cyclone
4 participants