Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(main/nodejs): 22.4.0 #20766

Merged
merged 1 commit into from
Jul 7, 2024
Merged

bump(main/nodejs): 22.4.0 #20766

merged 1 commit into from
Jul 7, 2024

Conversation

thunder-coding
Copy link
Member

@thunder-coding thunder-coding commented Jul 2, 2024

This PR is to just let @fornwall know that I've started working on the new release so that he doesn't duplicate the effort. I'll try to get the LTS version on track soon after

@thunder-coding
Copy link
Member Author

There is some minor regressions as indicated by the test suite. Here are some tests which are now failing but were previously passing:

Done running release test-child-process-default-options: FAIL
Done running release test-child-process-env: FAIL
Done running release test-permission-fs-symlink-target-write: FAIL
Done running release test-runner-output: FAIL
Done running release test-snapshot-reproducible: FAIL

Otherwise there is no major regression.

@thunder-coding
Copy link
Member Author

I just rechecked with older versions of node, and test-child-process-{default-options, env} are failing as well. This is as the test uses hardcoded paths, and internally node executes the child process using uv_spawn() which in turn calls execp(). So hardcoded paths are not being translated. We're only overriding execve() calls with termux-exec. I'll open a new issue to track and also override other exec* family of functions.

@thunder-coding thunder-coding merged commit 4f5429d into master Jul 7, 2024
0 of 4 checks passed
@fornwall
Copy link
Member

fornwall commented Jul 7, 2024

I'll open a new issue to track and also override other exec* family of functions.

@thunder-coding That is included in termux/termux-exec#24

Nice work keeping node.js up to date!

@thunder-coding thunder-coding deleted the nodejs-22.4.0 branch July 7, 2024 10:33
@thunder-coding
Copy link
Member Author

I'll open a new issue to track and also override other exec* family of functions.

@thunder-coding That is included in termux/termux-exec#24

Nice work keeping node.js up to date!

Thanks for linking your PR, I'd have totally missed it (didn't expect it to be with this large change).

And for keeping Node.js upto date, it all started with my needs and now I'm doing it for fun (although it's more of a pain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants