chore(main/miniupnpc): Disable auto-update #20790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better solution would be to check the soversion |
|
sorry for the break in a patch release. |
No problem. This will be just running in handful of phones not in hotels or banks or airlines 🙂 |
it fails at compile time, not at runtime :) |
|
Probably it is fine to go on using automatic updates if it happened only once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The miniupnp project may break API and/or ABI compatibiliity even in minor patch releases, so it's not safe to auto update (see miniupnp/miniupnp#758, and #20490 as an example what it can cause).
%ci:no-build