Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(main/pueue) #21104

Merged
merged 2 commits into from
Aug 12, 2024
Merged

enhance(main/pueue) #21104

merged 2 commits into from
Aug 12, 2024

Conversation

stevenxxiu
Copy link
Contributor

@stevenxxiu stevenxxiu commented Aug 12, 2024

This fixes some issues with the pueue package I submitted in addpkg(main/pueue): a command-line task management tool by stevenxxiu · Pull Request #20959 · termux/termux-packages:

  • Fix typo in Bash completions dir. I copied that from the starship package
    mkdir -p "${TERMUX_PREFIX}"/share/bash-completions/completions
    . You might want to fix this up. I thought it's nicer to not fix that in the same PR, as it's a separate package.
  • Run post_install after reinstalling or upgrading with Pacman, so the completions are generated. I tested that this works.

@TomJo2000
Copy link
Member

Oh you're right there is an extra s in there.
Welp that's what I get for testing with Zsh.

@TomJo2000 TomJo2000 merged commit eda5cdc into termux:master Aug 12, 2024
5 checks passed
@TomJo2000
Copy link
Member

We uh, forgot to bump the TERMUX_PKG_REVISION.
I'll fix it for both pueue and starship real quick.
Because I made the same mistake in 130a349.

@TomJo2000
Copy link
Member

Fixed in d0e929a.

@stevenxxiu stevenxxiu deleted the enhance(main/pueue) branch August 12, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants