Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NDK 23c patches #21499

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update NDK 23c patches #21499

wants to merge 1 commit into from

Conversation

EDLLT
Copy link
Contributor

@EDLLT EDLLT commented Sep 17, 2024

While testing different approaches to compile RNote, someone suggested that I attempt compiling it with an older NDK so I updated the patches needed for the NDK to work as the old patches don't apply anymore.
The patches needed were copied over from ndk 27's patches

@TomJo2000
Copy link
Member

I've just now had the time to get back to this.

@twaik
Copy link
Member

twaik commented Oct 19, 2024

Ping @licy183 @fornwall @finagolfin @Grimler91 because you commited to ndk-patches folder.

#include <stdarg.h>
#include <stddef.h>

+#if !defined(__swift__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, the Swift changes are mainly for compiling Swift source on a Termux device with the ndk-sysroot package. If you don't use Swift or compile on-device with this 23c sysroot, you don't need it.

@EDLLT EDLLT marked this pull request as draft October 22, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants