-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main/glib): completely remove gobject-introspection dependency #21766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e97ec56
to
a693194
Compare
So I consider it is fine, right? |
Almost, I missed your reply on the |
a693194
to
a5b1100
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, I have no claims to the commit in this PR, which solves the selected issues. But you need to understand that this does not replace PR #20513, since other issues are solved there. Also (so that you know) in PR #20513, it is planned to implement virtual packages, which will allow solving cyclic problems using compilation if the package installation is impossible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I was asking for this since the cyclic dependency appeared. Alpine Linux does similar steps to resolve the issue https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/glib/APKBUILD
Also 👍for the helpful comments in build script.
Fixes #20070
Fixes #20447
This PR lets us build glib without downloading prebuilt
gobject-introspection
dependency