Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main/glib): completely remove gobject-introspection dependency #21766

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

twaik
Copy link
Member

@twaik twaik commented Oct 10, 2024

Fixes #20070
Fixes #20447
This PR lets us build glib without downloading prebuilt gobject-introspection dependency

./build-package.sh glib

@twaik twaik requested review from Biswa96 and TomJo2000 and removed request for Grimler91 and finagolfin October 10, 2024 23:24
packages/glib/build.sh Outdated Show resolved Hide resolved
Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also consult with @Maxython on this,
as this approach would conflict with the one contained as part of #20513.

Overall, I do like this approach.
But there's a couple head scratchers in here and I would very much encourage more comments.

packages/glib/build.sh Outdated Show resolved Hide resolved
packages/glib/build.sh Show resolved Hide resolved
packages/glib/build.sh Show resolved Hide resolved
packages/glib/build.sh Outdated Show resolved Hide resolved
packages/glib/build.sh Outdated Show resolved Hide resolved
@twaik twaik requested a review from Maxython October 11, 2024 00:14
@twaik twaik force-pushed the glib-without-gobject-introspection branch 4 times, most recently from e97ec56 to a693194 Compare October 11, 2024 00:34
@twaik
Copy link
Member Author

twaik commented Oct 11, 2024

So I consider it is fine, right?

@TomJo2000
Copy link
Member

So I consider it is fine, right?

Almost, I missed your reply on the eval.
I'd still like to hash that out quick but other than that I think we're done with review.

packages/glib/build.sh Outdated Show resolved Hide resolved
@twaik twaik force-pushed the glib-without-gobject-introspection branch from a693194 to a5b1100 Compare October 11, 2024 00:45
@twaik
Copy link
Member Author

twaik commented Oct 11, 2024

Done.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've been making good progress on this PR,
and all my blockers are worked through.

But I'd like to wait for @Biswa96 and @Maxython to chime in before we merge this.

@Maxython
Copy link
Member

In principle, I have no claims to the commit in this PR, which solves the selected issues. But you need to understand that this does not replace PR #20513, since other issues are solved there. Also (so that you know) in PR #20513, it is planned to implement virtual packages, which will allow solving cyclic problems using compilation if the package installation is impossible.

Copy link
Member

@Biswa96 Biswa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I was asking for this since the cyclic dependency appeared. Alpine Linux does similar steps to resolve the issue https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/glib/APKBUILD

Also 👍for the helpful comments in build script.

@twaik twaik merged commit e350b46 into master Oct 11, 2024
7 checks passed
@twaik twaik deleted the glib-without-gobject-introspection branch October 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants