bump(main/shairport-sync): 4.3.4 #21970
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It starts and seems to work, but I can not test if it actually plays streams, I do not have Airplay-enabled devices.
Also it segfaults somewhere in
libsoxr.so
after receivingSIGINT
Probably the problem with destructors in
libsoxr.so
, needs further investigation.Also there are 42 more packages using pthread cancellation, probably we can make it work (with code from this PR) instead of patching it out.