Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addpkg(main/arti): 1.2.8 #21993

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

addpkg(main/arti): 1.2.8 #21993

wants to merge 1 commit into from

Conversation

thunder-coding
Copy link
Member

No description provided.

}

termux_step_create_debscripts() {
cat <<- EOF > ./postinst
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some review especially for this post install script

echo
echo "Arti is an EXPERIMENTAL implementation of existing CTor."
echo
echo "It is not recommended to use Arti unless you know what you are doing. It may not be up to mark with existing ctor in terms of stability, performance and MOST IMPORTANTLY SECURITY. Use Arti only if you want to help find bugs in the software"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like:

Suggested change
echo "It is not recommended to use Arti unless you know what you are doing. It may not be up to mark with existing ctor in terms of stability, performance and MOST IMPORTANTLY SECURITY. Use Arti only if you want to help find bugs in the software"
echo "It is not recommended to use Arti unless you have previous experience with Tor."
echo "It may not be up to parity with existing ctor in terms of stability, performance and MOST IMPORTANTLY SECURITY."
echo "Treat Arti moreso as an experimental package provided to find bugs in the project."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not nearly strong enough. The warning here is that this implementation is WIP and may wildly fail to provide the guarantees you're expecting of tor.

@thunder-coding I can offer some tweaks to the language, but first: tor is probably the closest thing we ship to safety-critical software. People do things that risk physical harm using tor because they believe it's trustworthy. The devs of this implementation are extremely clear that you should not be using it yet unless you are actively developing tor. Presumably, you felt the loudly repeat that in a postinst because you are aware that packaging something implies a high degree of out-of-the-box readiness.

If the only people who should be using this are developers, why do you want to package this, and is it a good idea to do so? My immediate read on this situation is "heck no".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, converting this PR to draft. Will keep on updating versions of arti as they come. Will start shipping this when Tor devs announce about declaring arti to be stable enough!

@thunder-coding thunder-coding marked this pull request as draft October 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants