Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main/luvi): fix incompatible bytecode error #22034

Closed
wants to merge 0 commits into from

Conversation

mbekkomo
Copy link
Contributor

@mbekkomo mbekkomo commented Oct 30, 2024

$ luvi . --
init.lua: cannot load incompatible bytecode
stack traceback:
        [C]: at 0x61b25d8c94
        [C]: in function 'require'
        [string "return require('init')(...)"]:1: in main chunk

This PR also bumps the commit used because previously the commit it was referencing did not exist.

@mbekkomo
Copy link
Contributor Author

From PR: #21722

Copy link
Member

@Grimler91 Grimler91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Please see comments/questions

@@ -17,36 +17,29 @@ TERMUX_PKG_EXTRA_CONFIGURE_ARGS="
-DWithPCRE2=On
-DWithSharedPCRE2=On
-DWithLPEG=On
-DLIBLUV_INCLUDE_DIR=${TERMUX_PKG_SRCDIR}/deps/luv/src
-DLIBLUV_LIBRARIES=${TERMUX_PREFIX}/lib/libluv.so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking the headers and the library should come from the same place/the same version. Why use -DLIBLUV_INCLUDE_DIR=${TERMUX_PKG_SRCDIR}/deps/luv/src and not -DLIBLUV_INCLUDE_DIR=${TERMUX_PREFIX/include/luv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to do that when trying to submit this package, it somewhat failed and I have no idea why. But I'll try to add it back.

Copy link
Member

@Grimler91 Grimler91 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we risk issues if version that is stored in luvi's deps/luv/src/ deviates (or starts to deviate in the future) from version that is stored in $PREFIX/, would be great if we could use $TERMUX_PREFIX/include/luv instead, so please check what error it gives

packages/luvi/build.sh Outdated Show resolved Hide resolved
@TomJo2000
Copy link
Member

Welp I tried to fix the branch being messed up, and messed it up even more by forgetting to commit.

@TomJo2000
Copy link
Member

TomJo2000 commented Oct 31, 2024

I might be able to fix it by reopening the PR.

Which I can't do because I re-pushed the branch with 0 commits...

@mbekkomo mbekkomo deleted the luvi-incompat-bytecode branch October 31, 2024 17:43
@Biswa96
Copy link
Member

Biswa96 commented Oct 31, 2024

Superseded by #22053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants