Update link to make them Obsidian compatible

[Portevent]

fix #6

[berniexie]

@Portevent typescript is failing, can you fix the errors please?

[berniexie]

@Portevent so right now we can link either to an internal page or an external link. If we add your code in, I think external links break. I wonder if there's a way to see if the link matches an internal doc and if not, keep it as an external link?

[alixander]

@berniexie why would external links break? this is just adding extra attributes, not changing any afaik.

But yes, there should be a way to identify external links: the presence of URL protocols. https://developer.mozilla.org/en-US/docs/Web/API/URL/protocol

What if users want to link to other resources though that are neither external nor Obsidian pages? Like a local PDF or image? /home/mycat.pdf. We should test that those work, if they were working before.

[berniexie]

local links were not working before

[Portevent]

@Portevent so right now we can link either to an internal page or an external link. If we add your code in, I think external links break. I wonder if there's a way to see if the link matches an internal doc and if not, keep it as an external link?

I don't think that would affect external link. But in case I added a check to skip external link. I made the assuption any external link follows the pattern <protocol>:\\<adress>, but we can change the regex if something is more suited.

[berniexie]

@Portevent
Changes look good to me, made some small tweaks. However, the commit "Fix typescript & only apply modification to internal link" is unsigned though, can u fix that please

[korniychuk]

Really waiting for this PR delivered 🙏

[gavin-ts]

rebased to resolve conflicts + sign the unsigned commit