Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement 206 - Fix urgent issue of parameter name check #346

Closed
wants to merge 1 commit into from

Conversation

namsonx
Copy link
Collaborator

@namsonx namsonx commented Oct 17, 2024

Hello Thomas,

I created the small change for enhancement 206 - Validity pre-check for variable names for release 0.13.0.

Thank you,
Son

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,

this change has side effects (compared with the JsonPreprocessor version from last month). And this change did not came from stabi branch, but from another one. Is the change in this branch made based on the stabi branch? Or in other words: Which branch shall I use for further testing while reworking the self test?

In earlier version I got this error message in case of a reserved keyword is used:

'The JSONP content contains a reserved token '__handleDuplicatedKey__00''

In this branch the error message is:

''int' object has no attribute 'pop'' (that is not like expected)

In current stabi branch the error message is correct:

'The JSONP content contains a reserved token '__handleDuplicatedKey__00''

And there are other differences. Maybe it's better to integrate this fix into the stabi branch and skip this branch.

@namsonx
Copy link
Collaborator Author

namsonx commented Oct 18, 2024

Hi Son,

this change has side effects (compared with the JsonPreprocessor version from last month). And this change did not came from stabi branch, but from another one. Is the change in this branch made based on the stabi branch? Or in other words: Which branch shall I use for further testing while reworking the self test?

In earlier version I got this error message in case of a reserved keyword is used:

'The JSONP content contains a reserved token '__handleDuplicatedKey__00''

In this branch the error message is:

''int' object has no attribute 'pop'' (that is not like expected)

In current stabi branch the error message is correct:

'The JSONP content contains a reserved token '__handleDuplicatedKey__00''

And there are other differences. Maybe it's better to integrate this fix into the stabi branch and skip this branch.

Hello Holger,

Actually, I created this commit (0edb72543) on stabi branch, then I created new branch namsonx/urgent/fix from develop branch and cherry-pick only this commit from stabi branch to namsonx/urgent/fix.

The purpose is: I found the issue with Enhancement 206, and the implementation of this enhancement already merged to develop branch.

I didn't merge stabi branch to develop branch due to there are many enhancements need the confirmation from you.

Regarding the issue The JSONP content contains a reserved token '__handleDuplicatedKey__00' you mentioned in your comment, it's fixed on stabi branch but not merged to develop branch yet. That the reason, you still observe this issue on namsonx/urgent/fix branch.

I hope my explanation is clear to you, and sorry for the inconvenience!

Thank you,
Son

@namsonx namsonx closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants