Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix role assignment for imgs with alt attribute #1236

Closed

Conversation

brtrick
Copy link

@brtrick brtrick commented Jun 14, 2023

What:
This PR fixes a bug in assigning the role to imgs.
Fixes #1235

Why:

How:

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • TypeScript definitions updated N/A
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 14, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4dcc5d1:

Sandbox Source
react-testing-library-examples Configuration

@MatanBobi
Copy link
Member

I'm closing this one because AFAIU it's resolved by #1241.
@jlp-craigmorten, @brtrick if I got it wrong, please comment here and I'll re-open :)
Thanks for the time working on this one!

@MatanBobi MatanBobi closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images with alt attributes cannot be grabbed ByRole
2 participants