Skip to content

Commit

Permalink
fix: remove wait-for-expect from dependencies (#205)
Browse files Browse the repository at this point in the history
**What**:

Remove unused dependency from `package.json`

**Why**:

This package is not used here directly. Dom-testing-library uses it though and declares it there already: https://github.com/kentcdodds/dom-testing-library/blob/master/package.json#L43

On the other hand, in case if dom-testing-library would use a new major version of the dependency, there will be unwanted package duplication, because this line will stay. 

Packages should not declare dependencies on other packages, that they actually do not use.

**Checklist**:

- (N/A) Documentation 
- (N/A) Tests 
- [x] Ready to be merged
      <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- (N/A) Added myself to contributors table 
      <!-- this is optional, see the contributing guidelines for instructions -->

<!-- feel free to add additional comments -->
  • Loading branch information
just-boris authored and Kent C. Dodds committed Oct 22, 2018
1 parent 468223b commit fe3b65c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@
"author": "Kent C. Dodds <[email protected]> (http://kentcdodds.com/)",
"license": "MIT",
"dependencies": {
"dom-testing-library": "^3.9.0",
"wait-for-expect": "^1.0.1"
"dom-testing-library": "^3.9.0"
},
"devDependencies": {
"@reach/router": "^1.2.1",
Expand Down

0 comments on commit fe3b65c

Please sign in to comment.