Skip to content

Commit

Permalink
Remove oudated tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nygrenh committed Feb 28, 2024
1 parent 9a35090 commit a0c583e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 76 deletions.
14 changes: 0 additions & 14 deletions spec/features/teacher_has_admin_abilities_to_own_course_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,20 +74,6 @@
expect(page).not_to have_content('0/6')
end

scenario 'Teacher can make code review' do
visit '/org/slug/courses/1'

expect(page).to have_content('1 code review requested')
click_link '1 code review requested'
click_link 'Requested'
# click_link 'Start code review'

fill_in('review_review_body', with: 'Code looks ok')

page.execute_script("$('form#new_review').submit()")
expect(page).to have_content('None at the moment.')
end

scenario 'Teacher can manage course feedback questions' do
visit '/org/slug/courses/1'
click_link 'Manage feedback questions'
Expand Down
62 changes: 0 additions & 62 deletions spec/usermanual/teachers.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -573,68 +573,6 @@ Some common examples:
</ul>
</p>

<h2>Code review</h2>

<p>
Code reviewing is a process in which a course teacher or an assistant goes over the code in a submitted answer and reviews it, providing comments for the students. Some exercises require a codereview to be completed. Students can also manually request a code review.
</p>
<p>
If there are any unreviewed requests, the course front page has a link 'n code view requested'. You can start the review process by clicking on that link. Furthermore, the submission list on the bottom of the page shows whether each submission requires a review.
</p>


<%
student = FactoryBot.create :verified_user, login: 'student', email: '[email protected]'
course = Course.find(2)
exercise1 = course.exercises.find_by(name: 'Week1-HelloWorld')
submission = FactoryBot.create :submission, course: course, user: student, exercise: exercise1, requests_review: true
submission_data = FactoryBot.create :submission_data, submission: submission
available_point = FactoryBot.create :available_point, exercise: exercise1
available_point.award_to(student, submission)

visit '/org/hy/courses/2'
highlight 'a:contains("Requested")'
highlight 'a:contains("1 code review requested")'
%>
<%= screenshot %>

<p>
The Review page shows all submissions which still require reviews. Click the 'Requested' link for the submission you want to review.
</p>

<%
click_on '1 code review requested'
highlight 'a:contains("Requested")'

%>
<%= screenshot %>

<p>
On the review screen, you can see student's code at the bottom of the page. Test result visibility can be toggled by clicking 'Test results'. When you have looked the code, click 'Start code review' to write your feedback.
</p>

<%
click_on 'Requested'
highlight 'button:contains("Start code review")'

%>
<%= screenshot %>

<p>
Write you review text in the text area. If you want to notify the student by email, you can check 'Notify
by e-mail' checkbox. When you are ready, click 'Save review'.
</p>


<%
click_on 'Start code review'
fill_in 'review_review_body', with: 'Code looks ok but you could...'
highlight 'label:contains("Notify by e-mail")'
highlight 'button:contains("Save review")'
sleep 1 # to prevent javascript animation to be captured
%>
<%= screenshot %>

<h2>Managing feedback questions</h2>

<p>
Expand Down

0 comments on commit a0c583e

Please sign in to comment.