Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding tcp-echo placeholder #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding tcp-echo placeholder #191

wants to merge 1 commit into from

Conversation

smarunich
Copy link
Collaborator

No description provided.

@smarunich smarunich requested a review from shamusx January 3, 2023 16:39
@smarunich smarunich marked this pull request as ready for review January 3, 2023 19:27
@smarunich smarunich marked this pull request as draft January 3, 2023 19:27
@smarunich smarunich marked this pull request as ready for review January 11, 2023 13:24
@smarunich smarunich requested a review from nacx as a code owner January 11, 2023 13:24
@nacx
Copy link
Member

nacx commented Jan 11, 2023

LGTM.

BTW, the obstester app already has an echo server running on port 3000, so technically the gitops eshop app is already exposing a TCP server in each service, in case you wanna leverage that instead of pulling a new app.

@smarunich
Copy link
Collaborator Author

oh cool, I will re-base to obstester! thank you @nacx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nacx nacx nacx approved these changes

@shamusx shamusx Awaiting requested review from shamusx shamusx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarunich @nacx