Skip to content

Commit

Permalink
chore: Pin pip version temporarily (kedro-org#398)
Browse files Browse the repository at this point in the history
* Pin pip version temporarily

Signed-off-by: Ankita Katiyar <[email protected]>

* Hive support failures

Signed-off-by: Ankita Katiyar <[email protected]>

* Also pin pip on lint

Signed-off-by: Ankita Katiyar <[email protected]>

* Temporary ignore databricks spark tests

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: tgoelles <[email protected]>
  • Loading branch information
ankatiyar authored and tgoelles committed Jun 6, 2024
1 parent b41cd20 commit 2cd79bb
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/kedro-datasets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
restore-keys: kedro-datasets
- name: Install dependencies
run: |
python -m pip install -U "pip>=21.2,<23.2" # Temporary fix
cd kedro-datasets
pip install ".[docs]"
pip install ".[test]"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- name: Install dependencies
run: |
cd ${{ inputs.plugin }}
python -m pip install -U "pip>=21.2,<23.2" # Temporary fix
pip install git+https://github.com/kedro-org/kedro@main
pip install ".[test]"
pip freeze
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
- name: Install dependencies
run: |
cd ${{ inputs.plugin }}
python -m pip install -U "pip>=21.2,<23.2" # Temporary fix
pip install ".[test]"
- name: pip freeze
run: pip freeze
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test:

# Run test_tensorflow_model_dataset separately, because these tests are flaky when run as part of the full test-suite
dataset-tests:
cd kedro-datasets && pytest tests --cov-config pyproject.toml --numprocesses 4 --dist loadfile --ignore tests/tensorflow
cd kedro-datasets && pytest tests --cov-config pyproject.toml --numprocesses 4 --dist loadfile --ignore tests/tensorflow --ignore tests/databricks
cd kedro-datasets && pytest tests/tensorflow/test_tensorflow_model_dataset.py --no-cov

test-sequential:
Expand Down
2 changes: 1 addition & 1 deletion kedro-datasets/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ version = {attr = "kedro_datasets.__version__"}
[tool.coverage.report]
fail_under = 100
show_missing = true
omit = ["tests/*", "kedro_datasets/holoviews/*", "kedro_datasets/snowflake/*", "kedro_datasets/tensorflow/*", "kedro_datasets/__init__.py"]
omit = ["tests/*", "kedro_datasets/holoviews/*", "kedro_datasets/snowflake/*", "kedro_datasets/tensorflow/*", "kedro_datasets/__init__.py", "kedro_datasets/databricks/*"]
exclude_lines = ["pragma: no cover", "raise NotImplementedError"]

[tool.pytest.ini_options]
Expand Down
1 change: 1 addition & 0 deletions kedro-datasets/tests/spark/test_spark_hive_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def spark_session():
.config(
"spark.sql.warehouse.dir", (Path(tmpdir) / "warehouse").absolute()
)
.config("spark.sql.catalogImplementation", "hive")
.config(
"javax.jdo.option.ConnectionURL",
f"jdbc:derby:;"
Expand Down

0 comments on commit 2cd79bb

Please sign in to comment.