Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns the dark mode ooc color back to blue #16774

Closed
wants to merge 1 commit into from

Conversation

jonash07
Copy link
Contributor

@jonash07 jonash07 commented Dec 1, 2024

About The Pull Request

My eyes are starting to bleed after looking at it for more than a single round.

Why It's Good For The Game

Soul revival.

Changelog

🆑
qol: dark mode ooc color is blue again
/:cl:

@tgstation-server tgstation-server added UI We make things worse, but rounder Quality of Life Minor changes that make the game nicer to play labels Dec 1, 2024
@yyzsong
Copy link
Contributor

yyzsong commented Dec 1, 2024

speedmerge

@Neocloudy
Copy link
Contributor

Neocloudy commented Dec 1, 2024

Use light mode, get used to/deal with the change like most people have, or simply go somewhere else. OOC was made yellow for accessibility/readability reasons (blue text on almost black background is ass), and the same goes for OOC announcements (changing the color of OOC announcements in particular was something ivan seemed to want, and I agree). Yellow OOC is also the default on almost every other codebase, so most new players will be used to yellow OOC.

If you aren't going to take any action to make this not an issue for yourself, at the very least put some effort into explaining why a PR removing a readability and uniformity/style change is good other than "I don't like it". Currently it just reads like you're removing this to start shit, or because you have an irrational dislike for any new features. There are honestly very few people I know that don't like this change.

@ivanmixo
Copy link
Contributor

ivanmixo commented Dec 1, 2024

Dark blue on a dark background is terrible, absolutely no

@ivanmixo ivanmixo closed this Dec 1, 2024
@jonash07 jonash07 deleted the makes_ooc_great_again branch December 23, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Minor changes that make the game nicer to play UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants