-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thanos] Changes to address querying multi cluster reads using thanos query #7781
base: main
Are you sure you want to change the base?
[thanos] Changes to address querying multi cluster reads using thanos query #7781
Conversation
…g thanos query" This reverts commit 9cbc630.
da77408
to
711db92
Compare
@rishabhkumar92 could you specify what use case this change fulfils? Not quite sure what you are trying to achieve with this |
@saswatamcode I have been trying to use thanos querier + thanos sidecar to query Grafana Mimir which expects |
a5aa53b
to
4d03efa
Compare
d68e2f2
to
e3669a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Why not use something like https://github.com/thanos-community/thanos-promql-connector?
Thanks for suggestion. Using promql-connector will require similar changes like i added in this change but in 2 projects(both thanos and connector) because querier side changes can't be avoided. |
@GiedriusS can you help review this change. |
cc1842b
to
26e65fe
Compare
Signed-off-by: Rishabh Kumar <[email protected]>
d473259
to
566ccc2
Compare
Changes
This change is meant to address querying multi cluster reads using thanos query. I have been trying to make it work with Grafana Mimir backend(Thanos querier -> Thanos sidecar -> Grafana Mimir) which expects X-Scope-OrgID as header for all prometheus APIs. It addresses following fixes:
Verification
cc: @aallawala @callumj @edma2 @GiedriusS