Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customs map labels #852

Merged
merged 6 commits into from
Feb 9, 2024
Merged

customs map labels #852

merged 6 commits into from
Feb 9, 2024

Conversation

colinmyers37
Copy link
Contributor

[Customs Map Labels]

Added Labels of important locations to the customs map

Screenshot 2024-02-08 at 12 25 50 AM

Related Issues 🔗

Related to #840

@colinmyers37 colinmyers37 requested a review from a team as a code owner February 8, 2024 06:29
@colinmyers37
Copy link
Contributor Author

Feel free to leave any feedback on name changes or locations that I may have missed!

@Shebuka
Copy link
Contributor

Shebuka commented Feb 8, 2024

Love it!

Would you say that 80% size should be the default size?

Possible locations:

  • Warehouse 4 and 17
  • Bus Station (or Terminal)
  • Powerline Tower (hill)
  • 'USEC' -> Streamers (house). Do you call it USEC? We call it Streamers because it has the streaming setup on the 2nd floor.

@Shebuka
Copy link
Contributor

Shebuka commented Feb 8, 2024

.deploy to development

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Deployment Triggered 🚀

Shebuka, started a branch deployment to development

You can watch the progress here 🔗

Branch: 75d7816efb84ce3cdf1d9d0b0c158160dc339910

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Deployment Results ✅

Shebuka successfully deployed branch 75d7816efb84ce3cdf1d9d0b0c158160dc339910 to development

Show Results

https://624ecad6.tarkov-dev.pages.dev

@Razzmatazzz
Copy link
Member

Very nice!

Regarding USEC/Streamer, my group calls it USEC too. But I think Streamer House is fairly common too. 🤷‍♂️

@Shebuka
Removed all uppercase for extracts;
0f4a720 
Thinner outline and added shadow to labels;
20px default font size for labels
@Shebuka
Slightly better centering for labels;
c628c9a 
Adjusted size scaling for the new default font size
@Shebuka
Copy link
Contributor

Shebuka commented Feb 9, 2024

.deploy

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: c628c9ab0e0b96033ed4776721e483fc88b59d44

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Deployment Results ✅

Shebuka successfully deployed branch c628c9ab0e0b96033ed4776721e483fc88b59d44 to production

Environment URL: tarkov.dev

@Shebuka Shebuka merged commit e1795ea into the-hideout:main Feb 9, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shebuka Shebuka Shebuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinmyers37 @Shebuka @Razzmatazzz