Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate characters for player search #900

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

Razzmatazzz
Copy link
Member

@Razzmatazzz Razzmatazzz commented Mar 31, 2024

Player search now validates allowed characters for name searching, and displays an error if invalid characters are used.
image

Also catches errors in the turnstile widget component and shows appropriate errors.

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner March 31, 2024 18:53
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: player-search-validation

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch player-search-validation to production

Environment URL: tarkov.dev

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: player-search-validation

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch player-search-validation to production

Environment URL: tarkov.dev

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: player-search-validation

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Deployment Results ✅

Razzmatazzz successfully deployed branch player-search-validation to production

Environment URL: tarkov.dev

@Razzmatazzz Razzmatazzz merged commit b6fe45b into main Apr 1, 2024
2 checks passed
@Razzmatazzz Razzmatazzz deleted the player-search-validation branch April 1, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants