Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37466 - Support Zeitwerk loader #637

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ofedoren
Copy link
Member

@ofedoren ofedoren commented May 15, 2024

WIP

@ofedoren ofedoren force-pushed the feat-37466-support-zeitwerk branch from a14b6d4 to 4bdfeb8 Compare May 15, 2024 14:06
@ofedoren ofedoren changed the title Fixes #37466 - Support Zeiterk loader Fixes #37466 - Support Zeitwerk loader May 15, 2024
@ofedoren ofedoren force-pushed the feat-37466-support-zeitwerk branch from 4bdfeb8 to 026369b Compare June 22, 2024 14:56
@ofedoren ofedoren marked this pull request as ready for review June 22, 2024 14:57
@ofedoren ofedoren force-pushed the feat-37466-support-zeitwerk branch from 026369b to 79bc4de Compare July 8, 2024 15:02
@ekohl
Copy link
Member

ekohl commented Jul 8, 2024

Test failure is a GH timeout. Seeding worked with Ruby 2.7 and all the other tests pass so IMHO we can ignore it.

@ofedoren ofedoren force-pushed the feat-37466-support-zeitwerk branch 2 times, most recently from c85149e to 734de93 Compare August 30, 2024 12:34
@ofedoren
Copy link
Member Author

ofedoren commented Sep 3, 2024

Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green:
Screenshot_20240903_143351

@ekohl ekohl merged commit 7bc87fb into theforeman:develop Sep 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants