209587Update to use seeds.d and plugin assets. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foreman supports loading seeds from db/seeds.d and thus being able to define individual seeds and control the ordering similar to how Foreman core does. Plugin assets needs only be defined in the settings, and the plugin assets rake task will handle compiling the plugin assets properly.
| end | ||
| end | ||
| initializer 'foreman_plugin_template.assets.precompile' do |app| | ||
| app.config.assets.precompile += assets_to_precompile |
There was a problem hiding this comment.
I thought this was required if you were using rake assets:precompile to recompile the whole application. SETTINGS is enough if you're just using the plugin-specific asset precompilation, but for say, a source install with plugins then they'd do everything.
|
@ehelms amazingly this still applies without conflicts, but is it actually still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreman supports loading seeds from db/seeds.d and thus being able to
define individual seeds and control the ordering similar to how Foreman
core does. Plugin assets needs only be defined in the settings, and
the plugin assets rake task will handle compiling the plugin assets
properly.