Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Connection interface #5

Closed
wants to merge 1 commit into from
Closed

Remove Connection interface #5

wants to merge 1 commit into from

Conversation

wKich
Copy link
Member

@wKich wKich commented Sep 20, 2023

Motivation

Connection interface is used for @relation directive which is not part of this project anymore, because @relation directive is related to backstage catalog types

Approach

Remove unnecessary code which might cause conflicts if used in other projects

Signed-off-by: Dmitriy Lazarev <[email protected]>
@wKich wKich requested a review from cowboyd September 20, 2023 12:48
Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve, but these aren't specifically related to Backstage Catalog so much as any relay connection. That's the argument I see for leaving it in. I'll leave it up to you though.

@wKich
Copy link
Member Author

wKich commented Sep 27, 2023

It seems we have to leave Connection interface because it's used in #7

@wKich wKich closed this Sep 27, 2023
@wKich wKich deleted the dl/remove-connection branch September 27, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants