Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the CSS structure #864

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Fixed the CSS structure #864

merged 7 commits into from
Dec 18, 2023

Conversation

taras
Copy link
Member

@taras taras commented Dec 18, 2023

Motivation

The header was sticky and footer wasn't always visible this made navigation content flow under the header.

Approach

Used flex to create 3 areas - header, main, and footer. Main extends to fill all of the available space. I had to make sure that each of the containers inside consumed all available space.

@taras taras marked this pull request as ready for review December 18, 2023 15:04
@taras taras requested a review from cowboyd December 18, 2023 16:02
@cowboyd cowboyd merged commit 9072f8b into v3 Dec 18, 2023
3 checks passed
@cowboyd cowboyd deleted the tm/fix-page-structure branch December 18, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants