-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching docs in Deno.Kv and testable file system helpers #892
Draft
taras
wants to merge
19
commits into
tm/push-docs-to-tags
Choose a base branch
from
tm/testable-file-system-operations.ts
base: tm/push-docs-to-tags
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Caching docs in Deno.Kv and testable file system helpers #892
taras
wants to merge
19
commits into
tm/push-docs-to-tags
from
tm/testable-file-system-operations.ts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taras
force-pushed
the
tm/testable-file-system-operations.ts
branch
from
February 13, 2024 22:55
c54e7eb
to
c719e2d
Compare
Co-authored-by: Charles Lowell <[email protected]>
taras
force-pushed
the
tm/testable-file-system-operations.ts
branch
from
February 15, 2024 19:50
c719e2d
to
7578fd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I started rewriting the GitHub Actions workflows from #891 into Deno tasks. In the process, I realized that I would like to cache the contents of the docs directory so I can load it from Deno.Kv instead of untarballing the files in the Deno instance. As it was getting more complicated, I wanted to start building up helpers and ensure they were tested. I kept ballooning the requirements, but it's good practice.
Approach
useCwd
hook that usesCwdContext
for storing the current context.useReadDir
anduseMkdir
that areuseCwd
compatibleTODO
useCwd
doesn't actually work, it's something about the way I'm using scope.useReadDir
anduseMkdir
don't actually get the set value.