Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to contribute to www with VSCode #894

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

taras
Copy link
Member

@taras taras commented Feb 15, 2024

Related #893

Motivation

We want it to be easy for people to contribute to the website using VSCode.

Approach

Due to denoland/vscode_deno#787, imports are only read from the workspace's default deno.json file. Fortunately, we can trick VSCode Deno Plugin into reading the deno.json file from 'www' directory by creating a .code-workspace file that has www directory as the first in the list of folders. Since the core doesn't have dependencies, this issue will not effect the core folders.

  1. created www/www.code-workspaces file with www as first and main folder
  2. Added www/.vscode/settings.json with deno.enable: true to activate deno when it's root
  3. Added www directory to excludes .vscode/settings.json
  4. Added instructions to README.md that encourage users to read www/README.md for website contribution instructions
  5. Added instructions on how to use the www/www.code-workspaces file for contributing to the website.

@taras taras requested a review from cowboyd February 15, 2024 17:25
Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@taras taras merged commit 9dce9eb into v3 Feb 15, 2024
3 checks passed
@taras taras deleted the tm/add-vscode-workspace-workaround branch February 15, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants