-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added context documentation #905
Conversation
@cowboyd why is Lint failing here? https://github.com/thefrontside/effection/actions/runs/10638858208/job/29495674024?pr=905
|
@cowboyd I fixed the TOC sidebar but lint is not passing. |
@taras It looks like maybe line wrap is disabled and so it's wrapping to the same line? not sure. As for the content, this is really good, and I like cribbing from React. I do think that we should mention these pratical pieces of information:
|
Let's merge what we have and add to it |
The thing is that I don't think the advice to wrap in a I'd be happy to add this as this makes it really easy to slot in. |
@cowboyd I removed the naming convention section. DI should be a separate page in the advanced section. |
77659d7
to
c2ce1fd
Compare
Motivation
Context is a killer feature of Effection that we don't have documented on our website.
Approach