✨ Add sitemap.xml to website #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're moving to provide sitemaps for all our minisites as a mechanism to composing them into the main frontside.com website. This adds a sitemap plugin which provides a `/sitemap.xml` route that scans all application middlewares and if any of them produce a set of sitemap paths, it addes them to the sitemap. Right now, the sitemap plugin provides an API compatible version of the `route()` helper from revolution. The idea is that we can copy this plugin into our sites and use it until we settle on a good api. Then, we can either add it to revolution itself or maybe extract it into a contrib-like package.
taras
approved these changes
Sep 19, 2024
jbolda
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're moving to provide sitemaps for all our minisites as a mechanism to composing them into the main frontside.com website. This adds a sitemap plugin which provides a
/sitemap.xmlroute that scans all application middlewares and if any of them produce a set of sitemap paths, it addes them to the sitemap.Approach
Right now, the sitemap plugin provides an API compatible version of the
route()helper from revolution. The idea is that we can copy this plugin into our sites and use it until we settle on a good api. Then, we can either add it to revolution itself or maybe extract it into a contrib-like package.The sitemaps for the v2 docs needed to be extended because of the way docusaurus dynamically loads JavaScript.
Screenshots
Notes
This also includes an upgrade of Effection for the website to
3.0.3which is a requirement for the latest version of revolution.