Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race was failing because result of holt is a promise, but yield* wants an operation #914

Closed
wants to merge 1 commit into from

Conversation

taras
Copy link
Member

@taras taras commented Oct 25, 2024

Motivation

image

Approach

Wrap each shutdown promise in call

@cowboyd
Copy link
Member

cowboyd commented Oct 25, 2024

This would be a good fix, but we actually need to make a Task an operation, not just a promise for two reasons. 1) we want working with tasks to be fluent inside other operations and forcing a call() around them would get really tedious, really quick. 2) and this is really important, we need operations to resolve synchronously if possible, and always consuming a task as a promise will force it to delay to the until the next tick of the run loop. This could be detrimental for task supervision.

That's why we needed to go with #915

@cowboyd cowboyd closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants