Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to JSR #939

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Publish to JSR #939

merged 11 commits into from
Dec 20, 2024

Conversation

taras
Copy link
Member

@taras taras commented Dec 20, 2024 •
edited
Loading

Motivation

I want to update revolution and such to e4, but I'd like to consume it from JSR.

Approach

  1. Since we're not tracking version in deno.json, so I created a script that adds the version and other needed properties to deno.json before running npx jsr publish.
  2. I changed https:// imports to jsr since JSR doesn't allow these.
  3. I added explicit types to eliminate "slow types"
  4. I had to add --allow-dirty to jsr publish because deno.json becomes dirty after changes.
  5. Upgraded dnt

@taras taras requested a review from cowboyd December 20, 2024 02:41
@taras taras enabled auto-merge (squash) December 20, 2024 02:48
@taras taras requested a review from cowboyd December 20, 2024 20:28
cowboyd
cowboyd approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@taras taras merged commit f1de695 into v3 Dec 20, 2024
4 checks passed
@taras taras deleted the tm/publish-to-jsr branch December 20, 2024 20:32
taras added a commit that referenced this pull request Dec 21, 2024
@taras
Publish to JSR (#939)
e258362 
* Generating jsr.json and publishing from GA

* Appending to deno.json instead

* Don't need jsr.json anymore

* Added missing explicit types and replaced jsr dependencies

* Upgraded deno/dnt

* Fix fomatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowboyd cowboyd cowboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taras @cowboyd